Skip to content

updated dependencies for adk and aiplatform - #2825

Closed
tommywagz wants to merge 20 commits into
mainfrom
chore/dependency-updates
Closed

tommywagz wants to merge 20 commits into
mainfrom
chore/dependency-updates

Conversation

@tommywagz

Copy link
Copy Markdown
Collaborator

Updated the dependency conflict between Agents CLI and the brand-search-optimization agent; primarily the google-adk and aiplatform packages. Pictured below -

image

If this PR is approved I will raise another one updating the remainder of the recipes to use these dependencies.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated House Rules review — 0 finding(s).

Also, on lines this PR does not change:

  • contrib/python/brand-search-optimization/app/shared_libraries/constants.py:24 — [MINOR] env read carries a hardcoded default (second argument is a hardcoded default); 7 occurrence(s) across 1 file(s). Defaults belong in .env.example, not in the code (contrib/python/brand-search-optimization/app/shared_libraries/constants.py:24; and 5 more)

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated Maintainability review — 1 finding(s).


Round 1 · 0 of this PR's 25 automated comments used · this round is capped at 20 across all reviewers.

PROJECT = os.getenv("GOOGLE_CLOUD_PROJECT", "EMPTY")
LOCATION = os.getenv("GOOGLE_CLOUD_LOCATION", "global")
MODEL = os.getenv("MODEL")
MODEL = os.getenv("MODEL", "gemini-3.7-flash")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[MINOR] Can we keep the fallback default in .env.example and read MODEL without an inline default? Hardcoded model defaults in code split configuration between source and environment files.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated Correctness review — 1 finding(s).


Round 1 · 0 of this PR's 25 automated comments used · this round is capped at 20 across all reviewers.

"google-adk>=2.6.0,<3.0.0",
"google-cloud-aiplatform[agent_engines]>=1.93.0",
"google-adk>=2.12.0,<3.0.0",
"google-cloud-aiplatform[agent-engines]>=1.156.0,<2.0.0",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[MAJOR] Perhaps this should be agent_engines instead of agent-engines? The package extra uses an underscore.

eliasecchig and others added 19 commits November 4, 2026 06:59
…number (#2563)

Co-authored-by: tommywagz <64981171+tommywagz@users.noreply.github.com>
…talog scanner (#2829)

Co-authored-by: Gabriela Hernandez Larios <gabrielahl@google.com>
Co-authored-by: Shahin Saadati <happyhuman@users.noreply.github.com>
…ve Computer Use alias workarounds (#2827)

Co-authored-by: Anaelle Drai Laguens <adrailaguens@google.com>
Co-authored-by: Shahin Saadati <happyhuman@users.noreply.github.com>
Co-authored-by: Gabriela Hernandez Larios <gabrielahl@google.com>
Co-authored-by: tommywagz <64981171+tommywagz@users.noreply.github.com>
… after Enter (#2854)

Co-authored-by: tommywagz <64981171+tommywagz@users.noreply.github.com>
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

This PR changes 1430 files, above the 300 GitHub's diff API will serve, so automated AI review was skipped. Splitting it up would get each part reviewed.

@tommywagz tommywagz closed this Nov 4, 2026
@tommywagz

Copy link
Copy Markdown
Collaborator Author

Depricated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants